Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add next card due message #16566

Merged
merged 1 commit into from
Jun 10, 2024
Merged

add next card due message #16566

merged 1 commit into from
Jun 10, 2024
+41 −8

Conversation

MorenoTropical
Copy link
Contributor

Purpose / Description

Improve the message

Fixes

Approach

I followed what anki does in https://github.com/ankitects/anki/blob/9b4dd54312de8798a3f2bee07892bb3a488d1f9b/ts/routes/congrats/lib.ts#L8C17-L8C34

How Has This Been Tested?

hours.webm
minutes.webm

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Message to maintainers, this PR contains strings changes.

  1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
  2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

@user1823
Copy link
Contributor

user1823 commented Jun 7, 2024

This message seems to be incomplete. It says "Congratulations", which is followed by "next card will be ready in ...". So, it gives the impression that the user is being congratulated because they will have a card due soon rather than for completing the reviews.

What about using “Reviews completed for now! Next card due in 5 minutes.”?

@MorenoTropical
Copy link
Contributor Author

Now is Deck finished for now! Next card due in 5 minutes

BrayanDSO
BrayanDSO approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the links.

@BrayanDSO BrayanDSO added the Needs Second Approval Has one approval, one more approval to merge label Jun 9, 2024
david-allison
david-allison approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers

@david-allison david-allison added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jun 10, 2024
@david-allison david-allison mentioned this pull request Jun 10, 2024
Merged
@david-allison david-allison added this pull request to the merge queue Jun 10, 2024
Merged via the queue into ankidroid:main with commit 7072592 Jun 10, 2024
8 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Jun 10, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jun 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

@user1823 user1823 mentioned this pull request Jan 7, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrayanDSO BrayanDSO BrayanDSO approved these changes

@david-allison david-allison david-allison approved these changes

Assignees
No one assigned
Labels
Strings
Projects
None yet
Milestone
2.19 release
Development

Successfully merging this pull request may close these issues.

After completing a deck, show "Next learning card will be ready in ⁨⁨..."
4 participants
@MorenoTropical @user1823 @david-allison @BrayanDSO